QuickReactions icon indicating copy to clipboard operation
QuickReactions copied to clipboard

List of issues

Open jeffhandley opened this issue 10 years ago • 3 comments

http://jeffhandley.github.io/QuickReactions/02-jsx.html

  1. More instances of -- being replaced with –. Particularly in “Get the react-tools installed” section.
  2. I also had trouble running npm install --global. I didn’t have permission to write to /usr/local/lib/node_modules, so I had to sudo that command.
  3. Then, for some reason, on ubuntu, the command ‘node’ didn’t exist, so I had to run ‘sudo ln -s /usr/bin/nodejs /usr/bin/node’ to get jsx to work.

http://jeffhandley.github.io/QuickReactions/03-gulp-workflow

  1. You got the -- thing right this time, but I had the same permissions problem with --global.
  2. It wasn’t obvious that the second chunk of code (the one right after the paragraph that starts with “But then we’ll create...”) was supposed to go into the same gulpfile.js – in fact it replaces the contents of it.
  3. You have a broken link to the next page. It’s set to http://jeffhandley.github.io/QuickReactions/4-gulp-node, when the four should be preceded by a zero.

http://jeffhandley.github.io/QuickReactions/06-gulp-workflow

  1. There’s no instruction to npm install gulp-watch --dev-save

http://jeffhandley.github.io/QuickReactions/17-structure

  1. It looks like you had to change the requires to turn “../lib/Components” into “../Components”. This wasn’t in the tutorial.

jeffhandley avatar Sep 22 '15 22:09 jeffhandley

Hi Jeff.

I'm going through your tutorial, and very much appreciate how you've laid it out.

I've just got started, and have run into a few minor issues. I'm finding workarounds, but I'm not sure if they're good enough for pull-requests yet.

How would you like these raised -- new issues in the issue tracker? Or are you maintaining a list here?

Here's what I've got so far:

  1. react-tools are deprecated and Facebook recommends moving to Babel.
  2. React.renderToString is deprecated, and fixed by using ReactDOMServer.renderToString from require('react-dom/server'), which in turn would mean adding npm install react-dom --save or similar in chapter 2: React's JSX Syntax.

That's it for now. Thanks again for the tutorial!

austinjp avatar Mar 05 '16 13:03 austinjp

Thanks for the feedback! I haven't updated the tutorial to keep up with those changes.

Would you be interested in adding a pull request to get it to to date?

jeffhandley avatar Mar 05 '16 17:03 jeffhandley

Hi again.

Unfortunately I'm now using survivejs.com as a tutorial. I've no doubt I'll encounter issues there too, it's a fast-moving world and nothing remains un-broken for long :)

Regarding the React.renderToString issue, I've added a PR for chapter 2 (untested). I'd guess that all these need replacing with:

var ReactDOMServer = require('react-dom/server')
...
ReactDOMServer.renderToString(...)

austinjp avatar Mar 08 '16 14:03 austinjp