vapaa icon indicating copy to clipboard operation
vapaa copied to clipboard

Module definition visibility

Open ivan-pi opened this issue 4 months ago • 1 comments

Currently, the mpi_f08 module just re-exports everything. It would be prudent to export the only entities which are meant to be public.

For instance, symbols from mpi_core_f including the names ending in _f08, global_handles_are_initialized, F_Check_design_assumptions, and others are included.

What would be the preferred approach to handle this?

  • adding only: ... clauses each imported module in mpi_f08?
  • adding private/public to each module (this might conflict with any unit tests)?

ivan-pi avatar Jul 11 '25 08:07 ivan-pi

Sounds fine to me. I just don't know how all this works because I'm not a Fortran module guru.

I do not have unit tests for any internal procedures. I exclusively test the MPI API.

jeffhammond avatar Jul 11 '25 15:07 jeffhammond