embedresponsively icon indicating copy to clipboard operation
embedresponsively copied to clipboard

Published 20 hours ago • verified publisher icon jeffehobbs

Getty Images

Open andrewhughey opened this issue 10 years ago • 5 comments

I'd love to see the new embedded Getty Images (http://www.bjp-online.com/2014/03/getty-images-makes-35-million-images-free-in-fight-against-copyright-infringement/) work responsively,

andrewhughey avatar Mar 07 '14 23:03 andrewhughey

@andrewhughey Me too -- literally looking into this right now. What's interesting about these embeds is that each individual one is potentially a different aspect ratio. So, math. :)

jeffehobbs avatar Mar 07 '14 23:03 jeffehobbs

Ah, missed your comment earlier. I gave it a shot with pull request #18.

andrewhughey avatar Mar 08 '14 02:03 andrewhughey

@andrewhughey check the http://embedresponsively.com/ site. If this solution works for you I'll check it into the main branch.

jeffehobbs avatar Mar 08 '14 19:03 jeffehobbs

It resizes down responsively just fine, but it also resizes up well above the image's actual dimensions.

Any reason you're keeping the height/width attributes in the iframe element?

andrewhughey avatar Mar 08 '14 20:03 andrewhughey

@andrewhughey In general, I try to keep the original embeds as intact as possible and just wrap them in a div. Having said that, it might be beneficial to impose a schema (http) and lose the w/h attributes. Let me think about it.

jeffehobbs avatar Mar 08 '14 23:03 jeffehobbs