Jeff Huber comments

Results 346 comments of


                                            Jeff Huber

JS client parity and broken out tests

@HammadB i went through every test and added verification of **values** for every test

Missing docstring for `increment_index` and duplicate docstring for `ids`

we are deprecating `increment_index` so im closing this issue

Organize Configuration Settings in config.py

Going to close this issue for now as it is `stale`. @adkri happy to re-open it if you like to jump back in!

Row Oriented `add`

Yes! I agree that the JS-column oriented should use destructuring like that - it would make the API much cleaner. The other case to consider here is `bulk_add` where users...

Row Oriented `add`

here is a proof of concept for a simple functional wrapper to enable this interface https://github.com/chroma-core/chroma/pull/719

Row Oriented `add`

closing in favor of this https://github.com/chroma-core/chroma/issues/420

pip install chromadb: mismatched binaries for dependency hnswlib on macOS arm64

@clstaudt it looks like you closed the underlying issue, https://github.com/nmslib/hnswlib/issues/454, so closing this one as well.

collection.query() should return all elements if n_results is greater than the total number of elements in the collection

Great point @fritzprix - this is being worked on upstream inside `hnswlib` - https://github.com/nmslib/hnswlib/issues/444#issuecomment-1493224811 - we also may handle it at the logic layer. You can check `collection.count()` to get...

Adds device (cuda) option for TransformerEmbeddingFunction

@spartanhaden this is a nice PR, thanks! Do you think we should proactively add any other inputs? https://www.sbert.net/docs/package_reference/SentenceTransformer.html#sentence_transformers.SentenceTransformer

Adds device (cuda) option for TransformerEmbeddingFunction

Note to self: resolve merge conflict and then merge