redux-logic icon indicating copy to clipboard operation
redux-logic copied to clipboard

Comment: include `import` statement in all examples

Open SilentCicero opened this issue 8 years ago • 1 comments

Please include all import statement in examples. Dont assume we know where things are being imported from.

Also, just another point.. this is awesome.

Also, any chance you can make this lighter? RXjs is cool, but such a large dep. I believe this could be done far lighter. Just an intuition..

SilentCicero avatar Feb 06 '17 19:02 SilentCicero

@SilentCicero Thanks for the tip. That's a good idea, always good to include the imports.

I'm using the latest version of RxJS v5, and since it allows custom builds, I am only including the Observable functionality (operators) that I am using. That results in a much smaller build than if you include the entire RxJS library. Last time I checked the production minified redux-logic including the custom RxJS was 11KB gzipped for both.

jeffbski avatar Feb 06 '17 20:02 jeffbski