ticgit icon indicating copy to clipboard operation
ticgit copied to clipboard

latest changes broke ti in specific usage scenario

Open jeffWelling opened this issue 13 years ago • 5 comments

Reposted as an issue on behalf of frioux who PM'd me to confirm this was a bug.

This is how I run ti:

alias ti='ruby -I~/code/ticgit/lib ~/code/ticgit/bin/ti'

In 1.0.2.6 it works perfectly, but in 1.0.2.7 and forward I now get the following error when I just run plain ti:

/usr/lib/ruby/1.8/git/lib.rb:643:in command': git log --pretty=raw -1 ticgit 2>&1:fatal: ambiguous argument 'ticgit': unknown revision or path not in the working tree. (Git::GitExecuteError)
Use '--' to separate paths from revisions
from /usr/lib/ruby/1.8/git/lib.rb:615:incommand_lines'
from /usr/lib/ruby/1.8/git/lib.rb:91:in full_log_commits'
from /usr/lib/ruby/1.8/git/log.rb:106:inrun_log'
from /usr/lib/ruby/1.8/git/log.rb:99:in check_log'
from /usr/lib/ruby/1.8/git/log.rb:80:ineach'
from /home/frew/code/ticgit/lib/ticgit-ng/base.rb:27:in map'
from /home/frew/code/ticgit/lib/ticgit-ng/base.rb:27:ininitialize'
from /home/frew/code/ticgit/lib/ticgit-ng.rb:46:in new'
from /home/frew/code/ticgit/lib/ticgit-ng.rb:46:inopen'
from /home/frew/code/ticgit/lib/ticgit-ng/cli.rb:24:in initialize'
from /home/frew/code/ticgit/lib/ticgit-ng/cli.rb:14:innew'
from /home/frew/code/ticgit/lib/ticgit-ng/cli.rb:14:in parse'
from /home/frew/code/ticgit/lib/ticgit-ng/cli.rb:9:inexecute'
from /home/frew/code/ticgit/bin/ti:13

ok, actually, it just seems like ti can't create a new ticgit branch anymore. Existing ti branches seem to work fine... Trying to see when that came in now...

Bisected the error to this commit: 9dcde196e85e956a6173b3371458fc145132bcbe

jeffWelling avatar Jul 15 '11 14:07 jeffWelling

Hmm. That commit was intended to fix a problem with cache corruption..

That is a peculiar usage scenario, but IMO there's no reason why it shouldn't work... Really sorry that broke for you though, if I'd known about that ticgit being used like that I could have tried harder to make sure not to break it lol.

Let me take a look at this some more....

I'm having trouble reproducing this bug... Can you provide any more information about your environment? What Ruby version are you using @frioux ?

jeffWelling avatar Jul 15 '11 14:07 jeffWelling

tungsten [20059] ~ <2> $ ruby --version ruby 1.8.7 (2010-08-16 patchlevel 302) [i686-linux]

Just whatever ubuntu comes with. Sorry I didn't get you a test case for this yet, I will, I'm just swamped at work.

frioux avatar Jul 15 '11 15:07 frioux

Hey no worries, I'll take as much [or as little] help as I can get. This is the last day of my vacation though, it's back to work full time for me next week. I'll still be here and will make a best effort to squash bugs but my time available for working on them will be significantly reduced.

jeffWelling avatar Jul 15 '11 16:07 jeffWelling

Hey, so I haven't been able to reproduce this bug and am headed back to work now so I won't have anywhere near as much time to work on it anymore. I'll keep poking and prodding it once in awhile in my free time, but for the most part you shouldn't count on me fixing this one in the near future just because I can't find the bug. Maybe once we both get some free time we'll be able to work out what it is that's revealing the bug to you and not to me, until then though it may be just you working on it for the time being. I'll post back here with any updates on my end, cheers :)

jeffWelling avatar Jul 16 '11 13:07 jeffWelling

@frioux Hey. Just wondering if you've had any luck or insight in finding out more about this bug? I haven't had any more time to investigate more on my end, but I hope to soon.

jeffWelling avatar Nov 10 '11 06:11 jeffWelling