code-eol icon indicating copy to clipboard operation
code-eol copied to clipboard

Compare view: EOL character not shown by default in left pane

Open Otiel opened this issue 6 years ago • 1 comments

Steps to reproduce

  1. Set "code-eol.toggleWithWhiteSpace": true (or don't set it, because it is true by default).
  2. Open a file.
  3. Make sure whitespaces are shown (call "View: Toggle Render Whitespace" if needed)
  4. Call the command "File: Compare Active File With..."
  5. Select another file.

Actual results

  • The left pane shows whitepaces, but no EOL character.
  • The right pane correctly shows EOL characters with whitespaces.

Expected results

  • EOL characters should be displayed in both panes.

Extra steps

  1. Set focus on the left pane. EOL characters are now displayed!

Video

gif

Otiel avatar Apr 12 '19 13:04 Otiel

Thanks for posting a video of it that is super helpful!

Right now the line endings get drawn because they're listening to a event like "document is active" or "edit document". I probably need to find another event for when the document is visible but not necessarily active. I'll start looking for that event, and once it's found this should be a 3 line fix.

jeff-hykin avatar Apr 12 '19 14:04 jeff-hykin