Jeff Cook

Results 23 comments of Jeff Cook

Here is an example of what that might look like. I have been testing with it and it is working so far. The versions should become variables, so it can...

Knowing what was ignored in the JSON would be ideal. The best option would be to show all entries in the ignore file, and which of them were also found...

I noticed a different issue talking about using line 0. I tried that and didn't change the outcome. The GitLab API does support, not using a line number. https://docs.gitlab.com/ee/api/discussions.html#create-new-merge-request-thread It...

I have updated to using line 1 for all issues with this tool. It functions, but not optimal as it will indicate the wrong location of the issue.

Looking at the API doc it is a little confusing. It does say `position[line_range][start][line_code]` is required, but I think that is only if you include `position` which is not required....

GitLab has the idea of resolve thread or discussion. That would be great to see. Not to delete the discussion, but to make it resolved. Having this cleaned up for...

Looks like the whois server doesn't exist. ``` nslookup whois.dotproregistry.net ** server can't find whois.dotproregistry.net: NXDOMAIN ```

Getting started with Danger and this is defiantly something I'm looking for. Thanks

How would the example above work if importing additional Dangerfiles? ```ruby danger.gitlab.newDiscussion((d) => { d.message("x") d.fail("y") }) ``` I would think having a config option to create the whole thing...