Jeffrey Chien

Results 14 comments of Jeffrey Chien

@bogdandrutu PTAL when you get the chance. Refactored the marshaler to be more similar to the unmarshaler.

Changed the `Marshallable` interface to take in a `confmap.Conf`. Added a function on the `confmap.Conf` that uses the encoder and uses `koanf.Merge` to "marshal" it into the `confmap.Conf`.

The Encoder handles all of the reflection needed to respect the mapstructure tags and is used by confmap to marshal. Without it, the marshal/unmarshal cycle would break and the configs...

> > The Encoder handles all of the reflection needed to respect the mapstructure tags and is used by confmap to marshal. Without it, the marshal/unmarshal cycle would break and...

Hi @ktrz, So, in my use case, the workflow where the action is used can be triggered by a workflow dispatch where the SHA is provided as an input. This...

@NathanielRN Running the `workflow_dispatch` is a manual process, but the same workflow is also triggered by a `repository_dispatch` from a different workflow. That's an interesting workaround. I suppose I could...

Did a bit of testing and it turns out that `decode` is called once for the base struct and once for each nested struct when decoding into a `map[string]interface{}` https://github.com/mitchellh/mapstructure/blob/bf980b35cac4dfd34e05254ee5aba086504c3f96/mapstructure.go#L989...

@nmamn Can you provide some additional context into the issue you're seeing? Which version of the agent were you seeing this in? Were there any logs indicating that the agent...

I would still rather have the marshaler skip the fields. Ran into this issue with another configuration in the contrib (https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/stanza/operator/input/tcp/tcp.go#L79) and, while that should be fixed as well, doing...

We've fixed this as part of https://github.com/aws/amazon-cloudwatch-agent/pull/847, which has been released as of v1.300028.0. The agent will now drop unsupported values like NaN and +/- Inf.