tabs icon indicating copy to clipboard operation
tabs copied to clipboard

Add TypeScript support

Open belozer opened this issue 5 years ago • 3 comments

Because typing is mainstream now

belozer avatar Nov 23 '19 23:11 belozer

Yup, I just installed this package and was ready to use it just to find out there are no types for it. So it would be great to add TypeScript support.
I had to go with "react-tabs" just because of this :(

Shaker-Hamdi avatar Dec 29 '19 17:12 Shaker-Hamdi

@Shaker-Hamdi why use react-tabs if you could temporarily add your own typings? The library is rather small so it shouldn't be lots of work.

sashayudaev avatar Feb 11 '20 15:02 sashayudaev

@sashayudaev When you're in a hurry to meet the deadline, any amount of extra work will hurt you. Plus I'm not that fond of Typescript, to begin with :D. So the idea of typing something that I didn't build myself and figuring out the types gives me anxiety just by thinking about it :D

Shaker-Hamdi avatar Feb 11 '20 16:02 Shaker-Hamdi