manim-slides icon indicating copy to clipboard operation
manim-slides copied to clipboard

fix(lib): prevent filename collision

Open jeertmans opened this issue 1 year ago • 1 comments

Apparently, ManimCE can produce two different animations with the same name (i.e., the same hash). As documented, ManimGL would anyway produce files with the same name, so this fix was needed.

Closes #428

jeertmans avatar May 10 '24 08:05 jeertmans

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.30%. Comparing base (962ff2b) to head (19c74f6). Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   79.33%   79.30%   -0.04%     
==========================================
  Files          22       22              
  Lines        1815     1822       +7     
==========================================
+ Hits         1440     1445       +5     
- Misses        375      377       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 08:05 codecov[bot]