JeecgBoot icon indicating copy to clipboard operation
JeecgBoot copied to clipboard

3.7.0 BasicForm component 为DatePicker或MonthPicker等组件下赋值默认值 defaultValue会报错

Open benben120 opened this issue 1 year ago • 1 comments

版本号:

3.7.0

问题描述:

BasicForm component 为DatePicker或MonthPicker等组件下赋值默认值 defaultValue会报错

截图&代码:

image image image image

前端安装环境:

如果你是启动报错,请说明你的前端环境

  • 采用的是pnpm安装还是yarn?
  • node版本号:?
  • pnpm版本号:?

友情提示(为了提高issue处理效率):

  • 未按格式要求发帖,会被直接删掉;
  • 请自己初判问题描述是否清楚,是否方便我们调查处理;
  • 描述过于简单或模糊,导致无法处理的,会被直接删掉;

benben120 avatar Jun 21 '24 06:06 benben120

@pujagani, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

github-actions[bot] avatar Mar 06 '23 12:03 github-actions[bot]

@diemol based on your comment here — https://github.com/SeleniumHQ/selenium/pull/12270#pullrequestreview-1502735591

I think we should close this issue. What do you think?

titusfortner avatar Dec 31 '23 16:12 titusfortner

@diemol based on your comment here — #12270 (review)

Note that we are most likely going to remove our partial CDP support before WebDriver BiDi is completely implemented. It may even happen later this year. As such leaving support around in Selenium might break users.

whimboo avatar Jan 02 '24 09:01 whimboo

@whimboo do you have an approximate date for that to happen? So we can synchronize.

diemol avatar Jan 05 '24 07:01 diemol

There is no clear date yet given that we still have a lot of work to do, but not before the next ESR 128 release. So at earliest for version 129.

whimboo avatar Jan 05 '24 07:01 whimboo

There is no clear date yet given that we still have a lot of work to do, but not before the next ESR 128 release. So at earliest for version 129.

We are in-par with our plan and the releases as mentioned above should hold. That means with Firefox 129 the CDP protocol will not be enabled by default anymore. For details see the following blog post:

https://fxdx.dev/deprecating-cdp-support-in-firefox-embracing-the-future-with-webdriver-bidi/

whimboo avatar May 31 '24 20:05 whimboo

Would be really nice if we could have the network/logging/script BiDi pieces implemented in Selenium before this happens

titusfortner avatar May 31 '24 21:05 titusfortner

Please note that this is not the complete removal. You would just have to set a preference for the default profile as in use for Firefox. Then CDP will be enabled. I assume that this could be implemented easily in necessary bindings?

whimboo avatar May 31 '24 21:05 whimboo

Maybe Selenium should toggle it on by default until we get bidi working? Depends on timing maybe

titusfortner avatar May 31 '24 23:05 titusfortner

That's probably a good idea. Do you or @pujagani know which APIs are still lacking WebDriver BiDi support and were implemented via CDP before?

whimboo avatar Jun 03 '24 09:06 whimboo

So at the Dev Summit a few weeks ago we agreed on what the High Level API should look like for BiDi. We haven't implemented it in any of the bindings yet. We have low level implementations of BiDi in some of the languages. I'm ok with not toggling CDP to enabled for Firefox once we have the High Level API implemented in the language.

titusfortner avatar Jun 03 '24 14:06 titusfortner

I think till we get to the point of implementing the High-Level APIs that were decided. We should probably toggle the CDP support on and keep. @whimboo I think the missing piece was allowing modifying the outgoing response body https://w3c.github.io/webdriver-bidi/#command-network-provideResponse. That is one that we need to implement NetworkInterceptor that uses CDP currently.

pujagani avatar Jun 04 '24 05:06 pujagani

I see. So @juliandescottes is currently working on these pieces and we hope that network.provideResponse will be available soon. AFAIK Chrome already supports that so that you potentially could start implementing it already. Given that we have a spec it should then not require any work (beside switching to bidi for sure) to enable it for Firefox as well.

whimboo avatar Jun 04 '24 06:06 whimboo

@pujagani hi!

As @whimboo said, I am currently working on support for network.provideResponse, hopefully it will be available in the coming weeks.

But considering that this feature was not available in Firefox with CDP at all, I don't understand why this is a blocker to stop using CDP for Firefox?

juliandescottes avatar Jun 04 '24 07:06 juliandescottes

Thank you for the update. That's great! @juliandescottes You have a valid concern. It is not a blocker to stop using CDP with Firefox. But if we were to deprecate/remove support for CDP in Firefox, we would want to point users to the new BiDi APIs. This change will probably need a blog post to redirect users to the new API. However, what we want to do is create and redesign all the high-level APIs listed here to use BiDi. So we will need them to be fully working with the browsers, else I am sure a lot of user might report errors back to Selenium even if the browser doesn't support it. Also, the NetworkInterceptor is the one of the most popular ones. I would prefer for it be fully baked it. Again, I understand the timelines and resources available so there is no urgency. It just the missing piece we are waiting for while we figure out the rest.

pujagani avatar Jun 04 '24 07:06 pujagani

@pujagani I assume that in that case one of you will take care of getting this preference set to the required value in one of the upcoming Selenium releases? Otherwise users, who are using CDP, will have to do it on their own when creating a new session.

whimboo avatar Jun 05 '24 06:06 whimboo

Sure. We can take care of it. Any documentation link that I can refer to regarding which preference needs to be set?

pujagani avatar Jun 06 '24 06:06 pujagani

Sure. We can take care of it. Any documentation link that I can refer to regarding which preference needs to be set?

Just check the Blog post that I referenced at https://github.com/SeleniumHQ/selenium/issues/11736#issuecomment-2142936951. Thanks!

whimboo avatar Jun 06 '24 06:06 whimboo

Sorry, I missed that. Thank you!

pujagani avatar Jun 06 '24 07:06 pujagani

@whimboo "Defaults to 3 (WebDriver BiDi and CDP)" - This is mentioned in https://firefox-source-docs.mozilla.org/remote/Prefs.html. Can we use that once CDP is deprecated? To ensure both protocols are active.

pujagani avatar Jun 07 '24 08:06 pujagani

Oh yes, you should definitely use 3 for that preference to have both CDP AND WebDriver BiDi enabled. I've updated our blog post to mention that as well. Thanks for noticing!

whimboo avatar Jun 07 '24 08:06 whimboo

Great! Thank you!

pujagani avatar Jun 07 '24 08:06 pujagani

Also, since it defaults to 3 (and that's what Selenium wants to use), do we need to explicitly set the preference?

pujagani avatar Jun 07 '24 11:06 pujagani

As mentioned on the blog post starting with Firefox 129 the preference will default to 1 which means WebDriver BiDi only.

whimboo avatar Jun 07 '24 11:06 whimboo

@pujagani and the merged PR is busted because it will only enable CDP and not BiDi. So please update it to 3.

whimboo avatar Jun 07 '24 11:06 whimboo

@pujagani and the merged PR is busted because it will only enable CDP and not BiDi. So please update it to 3.

Sorry, just noticed that this linked commit above is outdated and you already updated it on https://github.com/SeleniumHQ/selenium/pull/14091.

whimboo avatar Jun 07 '24 11:06 whimboo

Okay, got it. Thank you so much! I need to fix some tests in the PRs and will then merge it.

pujagani avatar Jun 10 '24 05:06 pujagani

Hi @pujagani. It's been a while since we spoke the last time. Would you mind sharing if there are some updates in Selenium about moving away from CDP in Firefox? We are getting closer to the removal date, so I would like to know if there are blocking issues. Thanks.

whimboo avatar Nov 12 '24 09:11 whimboo

Hey! I can loop this back to the Selenium TLC and see if get the support removed as soon as possible.

pujagani avatar Nov 14 '24 09:11 pujagani

Typically we deprecate a feature for 2 versions and then remove it. Our plan is to add deprecation warnings and then remove the support.

pujagani avatar Nov 14 '24 11:11 pujagani