Jed McCaleb comments

Results 65 comments of


                                            Jed McCaleb

[Compliance] allow_access endpoint records should be checked before calling ask_user callback

ask_user is a fallback in case allow_access fails. So it would be: ``` request_comes_in() { if(allow_access) { return: user info }else if(ask_user) { return: user info } return: no info...

[Compliance] allow_access endpoint records should be checked before calling ask_user callback

I haven't looked at the implementation. What I described is how it should work

[Compliance] allow_access endpoint records should be checked before calling ask_user callback

Yeah Rob's first interpretation is correct. To rewrite your code bartek: ``` if "record exists in a DB" { return compliance.AuthStatusOk } else { if rh.Config.Callbacks.AskUser != "" { //...

Change secret key fields type to "password"

I disagree. People shouldn't be using this if they need to maintain privacy. We should favor clarity

match submission response with subscription response

metadata vs meta one I fixed scott lets talk about the other one

move code in src/Ledger to use proper sql wrapper instead of legacy sql wrapper

If we are going to use this please pull it out of beast. We will hopefully drop beast at some point.

Should start explanded

I would start with everything expanded. I get what you are saying since that this is moving between pages rather than just being a single page it gets weird. @jessica-collier...

Visualizing The Bidirectionality of Trust Limits

Yeah the two table approach is fine. Thanks!

often encounter `noNetwork` error

You are running your own stellard or connecting to ours?

often encounter `noNetwork` error

It will say noNetwork when your stellard isn't synced to the network. It can take several hours to sync with the current codebase. We are trying to improve this.