swift-sodium icon indicating copy to clipboard operation
swift-sodium copied to clipboard

New Release Tag

Open code28 opened this issue 3 years ago • 8 comments

I need the commit 8f94369 in my code, but unfortunately in different libraries, so that SPM doesn't work using another reference than tags. So it'd be great, if you could add a new release tag for master's head. Thank you! 🙏

code28 avatar Mar 12 '21 08:03 code28

SPM let's you use master or a commit:

Screenshot 2021-05-24 at 21 31 38

johnalanwoods avatar May 24 '21 20:05 johnalanwoods

@johnalanwoods I know, but it fails, if your dependency uses this repo as well. (Even if both point to the same commit or branch.)

code28 avatar May 25 '21 06:05 code28

Oh wow. Ok. Which other lib are you using out of interest ?

infa-jowoods avatar May 25 '21 06:05 infa-jowoods

It's a private lib I use in different projects. (But I was able to remove the dependency on swift-sodium, so now it's possible to just use a revision in the main project. Nevertheless I think, a new release tag is necessary for swift-sodium.)

code28 avatar May 25 '21 09:05 code28

+1 on this

We need the change from https://github.com/jedisct1/swift-sodium/commit/ea3116e481179098b1ed6f0e1c477d5b36a9148d to support iOS 9+ in a pod we're distributing that depends on sodium. Podspecs don't allow us to point to anything other than a specific version number, so we need a version bump (preferably pushed to the pod trunk if possible) to get at that commit. And 0.8.0 won't pass a pod lint because of the Xcode 12 arm64 changes.

Or if anyone has better ideas, happy to hear them. But it does seem like this is a good solution since there's been a libsodium update and some good improvements since the last version bump.

Thanks!

samdowd avatar Sep 09 '21 20:09 samdowd

Hi @jedisct1 Can you please create a new release tag (and if possible release on CocoaPods CDN) to resolve this?

alexmorrisnz avatar Apr 14 '23 02:04 alexmorrisnz

@jedisct1 any updates?

Semty avatar Sep 29 '23 15:09 Semty

@Semty Any help on getting HKDF and AEGIS bindings that were introduced in libsodium 1.0.19?

jedisct1 avatar Sep 29 '23 16:09 jedisct1