libsodium
libsodium copied to clipboard
jedisct1
[dotnet core] build for linux-musl-arm64
Nice work 😃
The artifact (libsodium.so) also needs to be added to libsodium.pkgproj so it gets included in the NuGet package.
/cc @SeanMollet @enclave-alistair
libsodium.pkgproj looks good to me. While you're at it, you could also increment the version number in the same file.
Now someone needs to go ahead and test if the NuGet package actually works on their musl arm64 machine 😊
@ektrah That can be tested in a docker container. I might have some time later this week to build a proper test script for it.
libsodium.pkgproj looks good to me. While you're at it, you could also increment the version number in the same file.
Happy to bump the version - to 1.0.19.0?
Happy to bump the version - to 1.0.19.0?
That would be 1.0.18.3 (the third revision of the NuGet package containing pre-compiled binaries of libsodium 1.0.18).
@SeanMollet I'm happy to help with writing test scripts - I presume I need to build the package locally to test it? The CI process doesn't appear to publish it anywhere as far as I can tell.
@MichalPetryka, .NET doesn’t run on s390x. (Note that this particular PR is about the packaging of libsodium for .NET, not libsodium in general.)
@MichalPetryka, .NET doesn’t run on s390x. (Note that this particular PR is about the packaging of libsodium for .NET, not libsodium in general.)
It does with community builds, fedora package repository does provide s390x builds of it.
I'd be happy to do what I did for arm64 to add an arm build - would the maintainers prefer another PR for that? The issue now is testing though, which I'm happy to help with if I can, and if someone wants to give me a steer.