Frank Denis

`X509_VERIFY_PARAM_new()` returns `NULL` on allocation failure. `X509_VERIFY_PARAM_set_flags()` and `SSL_CTX_set1_param()` return 1 for success or 0 for failure. All these functions can fail. Can we check for these conditions?

> Set flags always returns 1, so no need to check it. It's OpenSSL. You can't expect internals not to change without prior notice, even in a minor revision.

Hi! The builtins need to be installed as well (`/usr/local/llvm/lib/clang/11.0.0/lib/wasi/libclang_rt.builtins-wasm32.a`). You can get them by compiling `clang_rt` from the `wasi-sdk` package, or directly download them [here](https://github.com/WebAssembly/wasi-sdk/releases) (`libclang_rt.builtins-wasm32-wasi-11.0.tar.gz`).

I tried to reproduce this. LLVM HEAD was compiled from source using the configuration above, and the linker found the `main` function just fine. ```text clang version 11.0.0 (https://github.com/llvm/llvm-project.git 8799ebbc1f03a348f732fc14242ad4c395076bcc)...

Same issue here... I don't get how to match an error type. Downcasting doesn't yield the same TypeId. Puzzled.

Ah. Looks like I've been confused by `bail!()` like everybody else :(

I agree that it doesn't simplify anything. The code is shorter, but less readable.

That can be worked around. What is the proper way to detect Windows 8.1 Mobile?

Maybe something like https://github.com/jedisct1/libsodium/commit/820c84ab894667f2ad0cef4e9cf849bee0a1fe71 can do the trick? Is `timeval` actually not being defined anywhere on this target? It's safe to remove the `randombytes_salsa20` folder from the project if you...

To work around the first issue, remove `|| defined(_MSC_VER)` in `pwhash_scryptsalsa208sha256_sse.c` and `crypto_scrypt-common.c`. The absence of `wincrypt.h` is more concerning. Try to remove the `#include ` statement in `utils.c` and...