Jed Cunningham
Jed Cunningham
Hey @sai3563, any luck?
Marking this for 2.5.0, but after the bulk of these changes land in a provider release, it'll work if you set the config.
I feel we should stick to a single style here, classic or taskflow. I'd be equally happy to have hello be a taskflow task too - I don't think we...
> I'm hesitant to show the TaskFlow style in this example because decorators are typically not learned on day 1 of Python. The home page should be understandable to all...
Overall looks okay. I do wonder if instead we should pass down the event itself instead. I could see custom manager classes wanting the dataset itself, so passing the event...
That's fair. I overlooked at they override `register_dataset_change`, not the others.
I wonder if the future annotations changes are going to cause heartache for #26290? Might be worth removing those here?
It's merged now, so just resolve the conflicts and we should be good to go.
We have a similar problem for celery workers too. I haven't given it a ton of thought, but I feel something like the breaking change as proposed above will be...
No objections here 👍