Jed Brown

Results 531 comments of Jed Brown

@mhoemmen :wave: How is your review going? I see you had a question about allocation tucked in the end of your comment. Faer supports `no_std`, which is an environment without...

@FCLC @mhoemmen :wave: Hi, could you let us know your timeline for finishing your review? Are there any hold-ups that Sarah or I could help with?

Yeah, [this](https://doc.rust-lang.org/book/ch11-01-writing-tests.html) is the pattern used for unit tests. It causes this code to be compiled out for regular use (in which case `cfg(test)` is false), but automatically put it...

> But, for the QFunction for loop, that would be 8 quadrature points per AVX register, not 8 elements. Is the idea just to keep the number of quadrature points...

It would depend on the loop body. For example, if it calls functions that don't vectorize (we did the series work with `log1p` because it doesn't vectorize in common implementations)...

In particular, the `v*pd` ("packed double") instructions, which I expect GCC is indeed emitting. I like to use Linux `perf` and then look at the hot instructions. If those are...

Thanks for your comments. Agreed about this being post-1.0. We wanted to get some feedback, but understand it can't merge during the feature freeze. Regarding reading in the mesh, we...

Thanks for the pointer to fcVM. Does it actually use the FEM Workbench? In the screenshots, I see it says "fcVM workbench" and does not inherit menus/icons from FEM Workbench....

Aakriti has moved on from our research group to a new role. I can rebase this branch, but it'll have to become a new PR since we can't update the...

Hi, @maxwxyz. I'll rebase and create a new PR (as noted https://github.com/FreeCAD/FreeCAD/pull/14667#issuecomment-2484275151). What would be a better place to discuss [these questions](https://github.com/FreeCAD/FreeCAD/pull/14667#issuecomment-2185037449) -- in particular I can't tell what is...