Jay Deng
Jay Deng
Potential duplicate: - https://github.com/opensearch-project/OpenSearch/issues/11374
If the test depends on a specific number of segments then can we [1] add an assertion for the segment count and [2] force merge to the correct number of...
> Is this actually faster? Got any micro benchmarks? Additional reference related to performance: https://github.com/opensearch-project/OpenSearch/issues/12102
@neetikasinghal could you please open manual backport PRs for both the `2.x` and `2.16` branches?
Looks like the [`MinDocCountIT.testDoubleCountDesc`](https://build.ci.opensearch.org/job/gradle-check/40485/testReport/org.opensearch.search.aggregations.bucket/MinDocCountIT/testDoubleCountDesc__p0___search_concurrent_segment_search_enabled___true___/) failure above is due to concurrent thread context modification bug for which fix has been merged: https://github.com/opensearch-project/OpenSearch/pull/14084
A quick scan through the other not post-merge related failures indicates that most of the other `MinDocCountIT` are due to the same issue fixed in https://github.com/opensearch-project/OpenSearch/pull/14084.
The failure for [`MinDocCountIT.testHistogramKeyDesc`](https://build.ci.opensearch.org/job/gradle-check/40463/testReport/org.opensearch.search.aggregations.bucket/MinDocCountIT/testHistogramKeyDesc__p0___search_concurrent_segment_search_enabled___true___/) looks like it's finding an incorrect doc count for a given bucket key when minDocCount is used. It's possible that this is due to concurrent search...
My hunch was that this could be similar to the issue in https://github.com/opensearch-project/OpenSearch/pull/9085 for terms aggregations, however based on https://github.com/opensearch-project/OpenSearch/blob/e3542011cd9584c354405ba6cbf9a31ced7bc5ce/server/src/main/java/org/opensearch/search/aggregations/bucket/histogram/InternalHistogram.java#L335-L337 it looks like `minDocCount` is only applied during the coordinator...
Thanks @navneet1v! I've created a meta issue to track all the implementation and design tasks related to this RFC: - https://github.com/opensearch-project/k-NN/issues/2391
Thanks for the suggestion @jainankitk! I had 2 initial thoughts: 1. I think you're proposing allowing the creation of feature branches that non-maintainers can push to directly, is that right?...