galene icon indicating copy to clipboard operation
galene copied to clipboard

dark mode for galene interface

Open RayBoucherit opened this issue 3 years ago • 5 comments

RayBoucherit avatar May 24 '21 13:05 RayBoucherit

There's a CSS media query for the color scheme ; the user sets that preference globally (in the browser or the OS). Galène can use it for the default color sheme. https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

MisterDA avatar May 24 '21 17:05 MisterDA

@takdj ?

jech avatar Jun 09 '21 13:06 jech

I think in this case, only color and background properties should be overwritten, for example:

.app-dark {
    background-color: #212529;
    box-shadow: 0 1px 1px 0 rgba(90, 89, 89, 0.06), 0 2px 5px 0 rgba(0, 0, 0, .2);
}

takdj avatar Jun 10 '21 06:06 takdj

@4h30, @takdj, what's the consensus on this?

jech avatar Aug 07 '21 16:08 jech

the dark mode feature is good but for me, It's required to update patch to change only color and background properties on dark mode. Else maintaining css will become harder. On javascript side, it's also better to set class 'app-dark' only on main div then, propagate dark style in css to children div.

takdj avatar Aug 09 '21 12:08 takdj