dht icon indicating copy to clipboard operation
dht copied to clipboard

Extended dht_get_nodes() parameters to get also a node id.

Open raspopov opened this issue 9 years ago • 3 comments

Both new parameters are optional and can be NULL.

raspopov avatar May 31 '15 08:05 raspopov

Do you mean a CHANGES file or something else?

raspopov avatar Jun 02 '15 16:06 raspopov

Yes, I mean the README.

jech avatar Aug 19 '15 00:08 jech

How about simply exposing struct node and return a list of all nodes? Then, the application can decide which information it needs. This would also allow for better monitoring as struct node contains other interesting data, e.g. when was the last reply etc.

This could be added additionally instead of modifying dht_nodes to keep compatibilty, e.g.:

int dht_get_nodelist(struct node *nodelist, int nodelistsize);

or

int dht_get_nodelist(struct node *nodelist, int nodelistsize, struct node *nodelist6, int nodelistsize6);

I'd be happy to finish this pull request and/or implement the above.

fonic avatar Apr 03 '18 08:04 fonic