Juliusz Chroboczek
Juliusz Chroboczek
Sure, no problem. However, since that would be a divergence from the JavaScript API, it would need to be clearly documented. If you choose to do that, please add a...
> Should we stay aligned with the javascript api or do our own thing? The JavaScript API is fairly high level. Pion is useful for low-level software, such as SFUs,...
It's a little bit more complicated than that. When using SetCodecPreferences in Pion, we set the ptype, and in particular we can set a ptype that is not defined in...
There appears to be multiple (related?) functionalities in this pull request, and I'm not quite sure what problems each of those is solving. I'd be grateful if you could squash...
> Edge routers should be able to retract default routes if they detect the upstream connection is failing. Simply deleting the default route did not work, and also is not...
> Do you have also a solution for propagating the source specific return routes? No, I don't think I have. Either we reinstate source-specific routing for IPv4 (which I removed...
At first sight, this looks very good. It's late now, so I may be saying something stupid, but shouldn't kernel_route take a prefsrc in all cases, not just in the...
Thanks for the PR. Sorry for the delay, you submitted it at a bad time and then it fell into the cracks. At first sight it looks good, please give...
I've applied the first two patches of your PR. In the third patch, I have a problem: why is applying the install filter conditional on newsrc being non-null? I think...
> 3rd patch: change_route is called by multiple code paths that do not change the src: install_route, uninstall_route, change_route_metric. All these do not change the pref_src, and the first run...