Juliusz Chroboczek

Results 202 comments of Juliusz Chroboczek

A suitable API has been merged. Plase see https://galene.org/README.API.html. (There's a very early prototype of an interface in the branch *management-ui*, but it's not usable yet.)

Hopefully fixed by 1afb3c8.

I'm not sure whether this is a bug. The callbacks are called synchronously, if they need to block, then you should make them asynchronous yourself. This is the usual idiom...

You've removed the tests? I don't agree, I think you should leave the tests. That way, when we adjust the tests, we know exactly how much the behaviour of the...

@midepeter why is this being committed with you as the author? Since I am the author of the code, I would expect to be credited. Please use the `--author` flag...

I fully support it. > Do you have any concerns/things I should be aware of? The main difference is that sample durations are off by one: my samplebuilder returns a...

https://github.com/jech/samplebuilder

> @jech What else needs to change/be added to the JitterBuffer implementation to be useful for your purposes. I'm not sure how I'm supposed to depacketise the output of the...

> Can you please provide a bit more detail? Unfortunately not. The log is all I have. > Now my understanding is that [...] can never be nil After staring...

Raja Subramanian on Slack: > We were hitting this in LiveKit server too. I checked Sean's partial revert PR (https://github.com/pion/turn/commit/9ebb7c76ea4102ee4150556b257dc043cdb87bb7) which went into this release and noticed that there was...