babeld icon indicating copy to clipboard operation
babeld copied to clipboard

Add functions to delete filters from an interface

Open PolynomialDivision opened this issue 3 years ago • 9 comments

Adding a delete function at runtime allows the babeld ipc to add and remove interfaces with filters. Further, it also allows more dynamic routing selection.

PolynomialDivision avatar Oct 20 '22 20:10 PolynomialDivision

I'm extremely confused. This PR appears to add two functions that are not used anywhere. Is part of the patch missing?

jech avatar Oct 30 '22 16:10 jech

It's used by the IPC I added in openwrt: https://github.com/openwrt/routing/pull/911/files

PolynomialDivision avatar Oct 30 '22 17:10 PolynomialDivision

I see. It feels weird to add dead code to babeld, so I'm hesitating between adding the funcitonality to babeld's native IPC, or to ask you to maintain it in your fork. Do you have any opinions?

jech avatar Oct 30 '22 18:10 jech

I can maintain it as patch. I just wanted to get some feedback from you if I can do such things. :)

PolynomialDivision avatar Oct 31 '22 09:10 PolynomialDivision

The code looks good to me.

Perhaps you could explain why you need this functionality, so we can think together whether there's a better solution to your problem?

jech avatar Oct 31 '22 10:10 jech

I'm adding and removing dynamically interfaces. Sometimes they even have the same name. I'm also adding filters on them. When I remove now an interface, I want to also to remove the filters. Maybe a clean removing of an interface and its filters would be some good solution for me.

PolynomialDivision avatar Nov 01 '22 11:11 PolynomialDivision

Maybe a clean removing of an interface and its filters would be some good solution for me.

You got it. Give me a few days.

jech avatar Nov 01 '22 12:11 jech

Thanks! :)

PolynomialDivision avatar Nov 01 '22 14:11 PolynomialDivision

Any news? :)

PolynomialDivision avatar Nov 20 '22 09:11 PolynomialDivision