Jeaye Wilkerson comments

Results 379 comments of


                                            Jeaye Wilkerson

Set and map literals should check for duplicate keys

The TODO for this is here: https://github.com/jank-lang/jank/blob/main/compiler%2Bruntime/src/cpp/jank/analyze/processor.cpp#L1245

`clojure.core/type` does not check `:type` meta

Not sure if we want this. jank's type system will be quite different, I think. It's also far more dangerous, in native land, to have the wrong type. I'll leave...

Unicode `U+2007` character treated as whitespace on macOS

I've seen this showing up on some people's machine. I suspected it was a locale issue on that machine, not having UTF-8 setup properly.

Unicode `U+2007` character treated as whitespace on macOS

Try this. ```diff diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ae4039a2..1f448f1c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -51,6 +51,9 @@ jobs: JANK_SANITIZE: ${{ matrix.sanitize }} ASAN_OPTIONS: detect_leaks=0 TERM: xterm + LC_ALL: en_US.UTF-8...

Unicode `U+2007` character treated as whitespace on macOS

I disabled the affected test for macOS only here: 77aa8de5dad5c837162590c189041668948e2863

`def` meta should be evaluated and support arbitrary values

Yep, we should follow Clojure here.

Cannot catch `std::runtime_error`

This is by design, which is not to say it's great. There is no base `Throwable` type in C++. *Anything* can be thrown. We can currently only catch jank objects...

Cannot catch `std::runtime_error`

> > It would be possible to add a wrapper jank object for std::exception, which is the base exception type for the C++ stdlib > > I guess you'd then...

Cannot catch `std::runtime_error`

Closing in favor of #558.

Use value-based exception handling

> Is this now just a "simple" task of implementation or is there more design left to be done? I think that it's mainly down to tackling the huge implementation...