racket-langserver icon indicating copy to clipboard operation
racket-langserver copied to clipboard

Different severity levels for code diagnostics

Open Eugleo opened this issue 5 years ago • 4 comments

Currently, all of the code diagnostics are of the lowest level, hint. It would be helpful to split them into error/warning/info. Is this a design decision, or just a temporary one?

Eugleo avatar May 01 '20 16:05 Eugleo

Temporary

On Fri, May 1, 2020 at 12:27 PM Evžen Wybitul [email protected] wrote:

Currently, all of the code diagnostics are of the lowest level, hint. It would be helpful to split them into error/warning/info. Is this a design decision, or just a temporary one?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jeapostrophe/racket-langserver/issues/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYZ6V3UK7JQYCBWU7VOXDRPL2ALANCNFSM4MXGREFA .

--

-- Jay McCarthy Associate Professor @ CS @ UMass Lowell http://jeapostrophe.github.io Vincit qui se vincit.

jeapostrophe avatar May 01 '20 16:05 jeapostrophe

That's good to hear. Looks like something a beginner like me could handle. I guess you'd like to stick to DrRacket's behaviour here as well. Is there any documented list of DrRacket's warnings/errors that we could use?

Eugleo avatar May 01 '20 16:05 Eugleo

Hmm... I think the best place to look would be in the translation files for DrR.

-- Jay McCarthy Associate Professor @ CS @ UMass Lowell http://jeapostrophe.github.io Vincit qui se vincit.

On Fri, May 1, 2020 at 12:36 PM Evžen Wybitul [email protected] wrote:

That's good to hear. Looks like something a beginner like me could handle. I guess you'd like to stick to DrRacket's behaviour here as well. Is there any documented list of DrRacket's warnings/errors that we could use?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jeapostrophe/racket-langserver/issues/14#issuecomment-622461747, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYZ6UMOVGASFE3N2ZL23LRPL3AZANCNFSM4MXGREFA .

jeapostrophe avatar May 01 '20 16:05 jeapostrophe

This issue is at least partially resolved by commit 61a7511. Reader and syntax errors are no longer reported as hints. There may be other DrRacket notifications that we're not displaying, so I'm leaving this open for now.

cfinegan avatar Jun 17 '20 02:06 cfinegan