jean-emmanuel
MIDI pass-through and OSC API extension
Hello,
Following the issue #31 I raised, I have attempted to implement a corrected version of MIDI pass-through (i.e. sending the MIDI signal through to the sequence's bus, without recording it). I also extended further the OSC API with the following:
- Create a new sequence
- Adjust the sequence's length (in beats per measure, beat unit, and number of measures), largely reusing the work from the pull request #16 (except the note editing functionalities which I didn't quite understand or need) and trying to implement some of the comments you provided in that thread
- Adjust the output bus and channel for the sequence
- extended sequence status JSON dictionary to include "through", "bus" and "channel"
This is pretty much the first time I successfully hack some C++ code, which I've done through a lot of copy-pasting and reverse engineering to compensate for my lack of code vocabulary and syntax, but hopefully it's not too bad. I've done quite some testing, although not pushed to the edges, let me know what you think and if you identify potential issues :)
Hi Thanks a lot for you contribution, I'm pretty busy at the moment but I'll review your code as soon as i have the time for it. I would be really nice if you could split it into two branches / pull requests (one per feature), that'd help me understanding what you wrote and allow testing them independently.
All right, I'll do that!
24 Aug 2023 11:42:52 jean-emmanuel @.***>:
Hi Thanks a lot for you contribution, I'm pretty busy at the moment but I'll review your code as soon as i have the time for it. I would be really nice if you could split into two branches / pull requests (one per feature), that'd help me understanding what you wrote and allow testing them independently.
— Reply to this email directly, view it on GitHub[https://github.com/jean-emmanuel/seq192/pull/32#issuecomment-1691357986], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AN7MZNUD5FUQFXRD2D7ZXALXW4OZVANCNFSM6AAAAAA32RJQMQ]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AN7MZNVCQEOKNATC5IK2FIDXW4OZVA5CNFSM6AAAAAA32RJQMSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTE2AJSE.gif]