mise icon indicating copy to clipboard operation
mise copied to clipboard

`bin/post-plugin-update` script

Open Hypnotist1148 opened this issue 2 years ago • 5 comments

The post plugin update script is not used yet. Also see: https://asdf-vm.com/plugins/create.html#bin-post-plugin-update

The environment variable ASDF_PLUGIN_PATH would also be important.

Hypnotist1148 avatar Feb 22 '23 18:02 Hypnotist1148

I haven't implemented these since I haven't seen a plugin that actually uses them. Do you know of one? It would be easier to test if I could run it against a real plugin vs just writing it to the spec.

I do have a spot for this though: https://github.com/jdxcode/rtx/blob/main/src/plugins/mod.rs#L168

jdx avatar Feb 22 '23 19:02 jdx

this might actually have unintended consequences since I suspect plugins doing this are likely to execute asdf. They're not supposed to do that and I have workarounds in place for it, but it's likely going to be a source of problems.

jdx avatar Feb 22 '23 19:02 jdx

I haven't implemented these since I haven't seen a plugin that actually uses them. Do you know of one? It would be easier to test if I could run it against a real plugin vs just writing it to the spec.

I don't remember any of the top of my head.

this might actually have unintended consequences since I suspect plugins doing this are likely to execute asdf. They're not supposed to do that and I have workarounds in place for it, but it's likely going to be a source of problems.

Yes this could be a problem!

Hypnotist1148 avatar Feb 22 '23 20:02 Hypnotist1148

I suppose we'll just leave this open until someone can tell me where it's actually used

jdx avatar Feb 22 '23 20:02 jdx

Maybe add a label like "help wanted"

Hypnotist1148 avatar Feb 23 '23 07:02 Hypnotist1148

it's crazy, it's been months and I literally haven't heard of a single time this has been needed. I'm going to close but happy to reopen if someone wants this.

jdx avatar Dec 03 '23 17:12 jdx