node-diskusage icon indicating copy to clipboard operation
node-diskusage copied to clipboard

Make diskusage Context Aware

Open larssvensby opened this issue 5 years ago • 4 comments

We use diskusage in an Electron application and Electron is soon requiring Native Modules in the Renderer Process to be NAPI or Context Aware.

Is it possible to make diskusage Context Aware? See https://github.com/electron/electron/issues/18397 and an example https://github.com/atom/node-keytar/pull/182/files

Thanks

larssvensby avatar Jan 23 '20 08:01 larssvensby

This looks relatively low cost, should be straightforward to add as well. I'll take a look at this over the next week, thanks!

jduncanator avatar Jan 24 '20 00:01 jduncanator

Thanks! I also saw this https://github.com/blagoev/node-diskusage/commit/d55db9d369b6c7728b97a2972232e66225c69bb4

larssvensby avatar Jan 24 '20 10:01 larssvensby

@jduncanator hey mate, any progress on making this context aware on NAPI? What do you think about https://github.com/blagoev/node-diskusage/commit/d55db9d ?

aleksey-hoffman avatar Apr 30 '20 12:04 aleksey-hoffman

@aleksey-hoffman Good Job!

xiaoxiangmoe avatar Sep 03 '20 13:09 xiaoxiangmoe