Johannes P. Dürholt

Results 150 comments of Johannes P. Dürholt

> so I'll clean up, take care of the feature importance functions and the hyperconfig, then you can review Thank you very much!

Oh, sorry. Totally forgot it. I will review it tomorrow. Can you make the branch up do date with the recent changes in BoFire?

Thanks @Osburg, it is not urgent, if we can get it sorted out somewhere over the next month, it would be great. Two other questions in this context (where the...

First question is clarified ;)

Hi @Osburg, thank you very much. I will have a look in the next days. Best, Johannes

Honestly, I do not know if I am the correct one to review :D @Osburg Do you check and fix the failing tests? I can then have a rough look...

@Balandat @saitcakmak any thoughts on this? ;)

The constructor of MixedSingleTaskGP is definitely a beast, I also run into other problems there today https://github.com/pytorch/botorch/pull/1568 So we first brainstorm how to refactor it before I implement the `categorical_kernel_factory`?

Fine for me! I try to put a PR together for this over the course of the next week!

Hi @LukasHebing, thanks! Can you rebase/merge with main so that we see here what is new and do not need to re-review the stuff that is already merged? Best, Johannes