Jérémie Drouet

icon indicating a website link https://jdrouet.github.io

icon company Previously @proton, @datadog and @docker icon location France icon location Senior rust software engineer from France transforming bread into lines of code.

Results 78 comments of Jérémie Drouet

Support void (self-closing) HTML elements in mj-raw

Hey, Could you provide an example? I'm already hunting them but some might not be caught by the CI

feat(mrml-core): add `Fragment` element

Moving your PR to draft considering the amount of commented code and the points mentioned.

feat(mrml-core): add `Fragment` element

This has been stuck for a while now, closing it

Website is 404

yeah, I had to shutdown my server. I will fix that when I'll have some time dedicated to the project.

[Pubsub] Use the default `pool_size` value when `None` is provided

Using a `NonZeroUsize` would be perfect 😉

Handle mj-html-attributes

Feel free to open a PR if you have some free time 😉

feat: add CSS inlining support for mj-style with inline attribute

@sciyoshi for me to keep track of your changes before approving the workflows AND for my reviews to stay attached to your code, could you push new commits instead of...

feat: add CSS inlining support for mj-style with inline attribute

> The only change from the original commit so far was to fix a clippy error and to add blocking as an option for reqwest to attempt to fix the...

feat: add CSS inlining support for mj-style with inline attribute

Hey, Sorry for the late reply and thanks for your changes. Could you put the `css_inline` behind a feature flag disabled by default? It's not just for the performance but...

feat: add CSS inlining support for mj-style with inline attribute

@sciyoshi could you resolve the conflicts so that we can trigger the tests?