Jacob Dreesen

Results 183 comments of Jacob Dreesen

I also think that this is an edge case and that we don't need to change the default setting.

Should we also dispatch a `POST_LOAD` event in `getById()` ([like here](https://github.com/pimcore/pimcore/blob/4ab36f85af7ead9a3591fff9eb10071f3c2e4474/models/DataObject/AbstractObject.php#L248-L251))? That would probably help with tagging whenever a website setting is used.

@mattamon unfortunately it's impossible to tell what actually changed in this PR because the CS fixer bot added so much noise :(

I think this needs to be done sooner than `12.0.0` because Twig just released a new version with a security fix (`3.14.0`), which means that Twig `

Are you using Pimcore 12? The deprecated [MultiSelectOptionsProviderInterface](https://github.com/pimcore/pimcore/blob/12.x/models/DataObject/ClassDefinition/DynamicOptionsProvider/MultiSelectOptionsProviderInterface.php) should have been removed with the release of Pimcore 12. But apparently that didn't happen... 😕

It seems that this library is not even used by Pimcore. Therefore, I think it can be removed instead.

Right, but just the class name for an `instanceof` check (in the `PropertyTypeMatcher`), and you can check against anything, the class doesn't need to exist, see: https://3v4l.org/9YmVm

How about refactoring `ClassSet` so that it can handle multiple directories instead? The constructor is `private` so we could change it (without BC break) and add a second static constructor...

Note that #18313 wants to change the same line.

For me, `patch-diff-links` is broken: > 12:57:46.803 📕 24.8.30 → TypeError: commitMeta is undefined Browser: Firefox 130