mkdocs-multirepo-plugin icon indicating copy to clipboard operation
mkdocs-multirepo-plugin copied to clipboard

Git version check fails to prevent sparse checkout failure (Windows)

Open thefuntastic opened this issue 1 year ago • 0 comments

I just ran into issue #37 - i.e. getting an odd failure on sparse checkout.

I see there is a git version check to try and defend against this issue, however, if invoking mkdocs build from cmd the version check will return the git version that's available on the windows path (on my system currently git version 2.39)

However, the sparse_checkout method invokes bash. On my system running bash from cmd automatically launches WSL which is a separate environment and will have its own version of git installed (which in this case was 2.25.1). A potential solution here could be to run a bash script that echos git version as the source of truth, and warn if the version is old.

However, I did also try run mkdocs build directly from WSL, which should have returned the correct version but also encountered failure. I see the version check is looking for < 2.25. Perhaps this should be bumped? On issue #37 it seems later minor versions of 2.25 fix the issue.)

Once I upgraded WSL to git v 2.40 then the script worked as expected.


(Also it's likely we're going with another solution, so unfortunately I don't think I'll have much bandwidth to follow up on this.)

thefuntastic avatar Jun 15 '23 08:06 thefuntastic