jkgfxmod
jkgfxmod copied to clipboard
Higher Brightness Bug
Hi
Higher Brightness Settings , and the Neuron Textures or some addon Textures Vanisch , and shows just the old one's Classic Textures !
The Effects from the JKGFX2019b Mod , still show up !
I'm not quite sure what this issue is trying to say, but the main menus do appear washed out compared to DgVoodoo. (I don't have a screenshot of what it looks like with jkgfxmod right now.)
Hi
Higher Brightness Settings , and the Neuron Textures or some addon Textures Vanisch , and shows just the old one's Classic Textures !
The Effects from the JKGFX2019b Mod , still show up !
The root cause of this issue is the method JK uses to implement the brightness slider. JK implements brightness by modifying the textures in memory to appear brighter. Fixing this issue would therefore require the following work:
- Reverse engineer the algorithm JK uses to adjust the textures. The obvious candidates are a colormap light level bias (easy) or something more cryptic implemented in code (hard).
- Use the reverse-engineered algorithm in
compile
to calculate hashes for the replaced textures at all brightness levels. The reverse engineered algorithm must be bit accurate, otherwise these hashes will not be correct. - Add brightness levels to the material map, so
renderer
can brighten the texture to match what the user expects.
Given the time involved and the meager utility of the brightness slider, I'm probably not going to implement this any time soon. I'm more inclined to fix this in doc and triage down (or just close wontfix).