Josh Matthews

Results 343 issues of Josh Matthews

We hold a mutable borrow of a field of HTMLImageElement at https://github.com/servo/servo/blob/main/components/script/dom/htmlimageelement.rs#L1272, then call a method that can trigger a GC at https://github.com/servo/servo/blob/main/components/script/dom/htmlimageelement.rs#L1283 while the borrow is still outstanding. We...

A-content/dom
E-less-complex
I-panic

There are several traits from script that block further propagation of CanGc at the moment: * VirtualMethods * Activatable * TaskOnce * FetchResponseListener We need to decide if it makes...

A-content/dom

This is a special case of #33683, because it requires a lot of repetitive work that all has to happen at once. Code: https://github.com/servo/servo/blob/f8933a57353aeca14a6cbc60b3cb0cf98cab6c5d/components/script/dom/bindings/reflector.rs#L34 There are many callers of this...

E-less-complex
A-content/script

``` ▶ TIMEOUT [expected PASS] /css/CSS2/css1/c43-rpl-ibx-000.xht │ │ VMware, Inc. │ softpipe │ 3.3 (Core Profile) Mesa 18.1.0-devel │ Failed to receive a response from live font cache (thread LayoutThread...

I-intermittent

The CanGc work is starting to return results! This code has a secret risk—we mutably borrow a field of XRInputSourceArray in https://github.com/servo/servo/blob/main/components/script/dom/xrinputsourcearray.rs#L39, then later call a method that can trigger...

E-less-complex
I-panic
A-xr-zomg

DOMRectList specification: https://drafts.fxtf.org/geometry/#DOMRectList getClientRects specification: https://drafts.csswg.org/cssom-view/#dom-element-getclientrects Instructions for adding a new interface to Servo: https://doc.servo.org/script/dom/index.html#adding-a-new-dom-interface The CSSOM specification must have been updated since we first added getClientRects: https://drafts.csswg.org/cssom-view/#extension-to-the-element-interface There's a...

A-content/dom
E-more-complex

https://www.w3.org/TR/WebCryptoAPI/#dfn-SubtleCrypto This is used in the hub.link flow for joining a hubs room on a VR device.

A-content/dom

``` │ assertion failed: self.fd == -1 (thread , at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ipc-channel-0.18.3/src/platform/unix/mod.rs:636) │ 0: servoshell::backtrace::print │ 1: servoshell::panic_hook::panic_hook │ 2: std::panicking::rust_panic_with_hook │ 3: std::panicking::begin_panic_handler::{{closure}} │ 4: std::sys_common::backtrace::__rust_end_short_backtrace │ 5: rust_begin_unwind │...

I-intermittent

We have a lot of Rust code that is generated at build time for each DOM interface. The code that generates it lives in https://github.com/servo/servo/blob/main/components/script/dom/bindings/codegen/CodegenRust.py. This file is very large...

A-content/bindings
I-refactor
B-meta

Test page: ```html window.onmessage = () => i.remove(); let i = document.createElement('iframe'); i.src = "iframe2.html"; document.body.appendChild(i); i.src = "iframe2.html"; ``` Framed page: ```html parent.postMessage('hi', '*'); ``` Backtrace: ``` Failed to...

A-content/script
C-has-manual-testcase
A-constellation
I-panic