Josh Matthews

@bors-servo r+

@bors-servo r+

Error syncing changes upstream. Logs saved in error-snapshot-1657142740626.

I wonder if those should be referring to Document instead of Window (https://github.com/servo/servo/blob/3bf1085c72d1bf05507c4755709e9c25c6ca4e7f/components/script/dom/document.rs#L247-L248)?

> I implemented getters for `id_map` and `name_map` to see if the build succeeds, but that got me into scary territory: > > ``` > error[E0133]: use of extern static...

https://github.com/servo/servo/blob/a955ff280d252468e22082beabcc9ca35577f3d9/components/script/script_thread.rs#L527 is a map of BrowsingContextId to WindowProxy, which I believe answers your first question!

Not to worry! If this is still something that you'd like to keep hacking on, you're welcome to it!

I'm pretty sure if you make iframes_iter: ```rust let iframes_iter = document .iter_iframes() .filter(|iframe| { if let Some(window) = iframe.GetContentWindow() { return window.get_name() == name; } false }) .map(|iframe| Root::upcast::(iframe))...

I was wrong; it's a bit more subtle than that because dereferencing a `Root` returns `&T` instead. I'm tinkering with it locally.

This makes the build succeed for me. I originally attempted to unify the three iterators to be over `&Element` instead of two of them being over `&Dom`, but that exposed...