ng-notyf icon indicating copy to clipboard operation
ng-notyf copied to clipboard

Position as a parameter.

Open alejandronanez opened this issue 7 years ago • 1 comments

Hey guys, I think it should be nice to do

this.notyfService.position("left / top-left / bottom-right / middle-left / etc...");

// instead of
this.notyfService.toastContainerStyle = { 'left': '0' };

I'm more a React guy so I'm not quite sure if what you do is a design standard for Angular plugins, also if this is something that should be done, I'd like to do work on it.

Keep me posted,

Thx.

alejandronanez avatar Jun 05 '17 10:06 alejandronanez

Hey @alejandronanez thanks a lot for your willingness to contribute to ng-notyf. Any help is always much appreciated.

Having the position as a configurable property takes a bit of work that includes: properly setting the component animation depending on the position of the container, exposing/exporting a proper enum representing the position, etc.

That being said, I want to open a PR proposing an initial implementation of the feature being discussed so you can know what to take into account if you would like to enhance this feature. Hope this makes sense to you.

Thanks again for opening the issue.

caroso1222 avatar Jun 08 '17 03:06 caroso1222