Papr icon indicating copy to clipboard operation
Papr copied to clipboard

Published 20 hours ago • verified publisher icon jdisho

Integrate JDToaster

Open jdisho opened this issue 5 years ago • 9 comments

Replace alerts with JDToaster.

jdisho avatar Sep 06 '19 07:09 jdisho

Can I take it?

artyom2206 avatar Nov 08 '19 14:11 artyom2206

Yes, you can, but let’s discuss it first in this issue @artyom2206.

jdisho avatar Nov 21 '19 15:11 jdisho

So i installed it to Papr and implemented instead of each alertAction, but there is a problem with JDToaster on new IOS 13.2 version. When the toast shows from the bottom, then it disappears(check GIF). Toast duration also not works, I called it manually(IOS 12.4). Should I do pull request?

(https://user-images.githubusercontent.com/47772683/69388436-25c74e80-0cc9-11ea-935a-3855fe85161a.gif)

artyom2206 avatar Nov 22 '19 00:11 artyom2206

This certainly does not look as I expected 🤔 Would you like to investigate the issue in the JDToaster and create a PR?

jdisho avatar Nov 22 '19 06:11 jdisho

Ok, I will look at it

artyom2206 avatar Nov 26 '19 12:11 artyom2206

Adding a strong reference to the UIWindow will solve the issue. @artyom2206

jdisho avatar Nov 28 '19 20:11 jdisho

The issue is fixed! I will do a release soon.

jdisho avatar Nov 29 '19 09:11 jdisho

Hey @jdisho Is this issue already fixed ? If not I'd like to contribute on that. Let me know at the earliest.

Dishant10 avatar Aug 04 '22 16:08 Dishant10

I don't know if this is relevant. As you may see, I'm not maintaining this app anymore 😴

jdisho avatar Aug 04 '22 17:08 jdisho