acid-tabs-extension icon indicating copy to clipboard operation
acid-tabs-extension copied to clipboard

Issue: pinned tabs get overriden

Open 17twenty opened this issue 3 years ago • 5 comments

I have a few pinned tabs that run my day - two Gmail inboxes, a yt music and a trello tab.

The plugin doesn't seem to work nicely with this and has rolled them into a Google tab.

Could it respect pinned tabs?

17twenty avatar Jul 04 '21 21:07 17twenty

Great find @17twenty, default behavior should be to leave pinned tabs alone.

jdhayford avatar Jul 05 '21 15:07 jdhayford

Unpinned tabs also stay separated from their categories.

unpin

oae avatar Jul 05 '21 17:07 oae

any updates on getting this to ignore pinned tabs?

WHiZSTA avatar Aug 18 '22 17:08 WHiZSTA

How about an alternative approach - treat pinned tabs as a kind of pseudo-tab, so you could set up a rule for them. Tabs matching the rule would be automatically pinned.

The pinning would have to always be the first rule, and since the first matching rule wins, tabs matching that rule would always be pinned, never grouped.

I'd be happy to take a run at a PR for this, though it might be a couple of weeks before I would get the time.

brunns avatar Aug 30 '22 15:08 brunns

tbh i'm already doing this as a temp workaround. I made a group named "|" and ordered it to be the first group, and set exact rules to put my pinned tabs in it. that way when it sorts they are always first. granted it's not the same as pinning, but it's close.

Maybe the quick fix is, when its sorting tabs, if the tab meets the rules for a saved groupname = "|" or "Pin".. or maybe at a checkbox called "ignored" for groups? and when it matches this item, ignore it, don't create the group or move the tab and skip to the next tab to sort. That way if you have the tab pinned it stays pinned as it's basically ignored.

WHiZSTA avatar Aug 30 '22 21:08 WHiZSTA