Refresh rate issues

[anxdpanic]

[anxdpanic]

Unable to determine a video's exact frame rate: https://github.com/jdf76/plugin.video.youtube/commit/ec4f8478f6b574484ada517ce5e74cb9957e4d25

[anxdpanic]

Resolved https://github.com/jdf76/plugin.video.youtube/issues/577#issuecomment-465197325 Thanks. There is another issue I have recognized with webm streams in general. The frame rate switch doesn't work immediately when the video starts but take one ms after start to get correct hz value:

• videos in 23,97/24 start with 23.00hz
• videos in 25fps stat with 24hz
• videos in 30 fps start with 29hz
• videos in 60fps start with 59hz

There is always a lack of 1 hz whether the video starts and then switch correctly after one second.

[greystashh]

Concerning vp9 streams this is different because kodi don't get the right fps rate from the add-on. You can see in this log: https://filebin.ca/4XbxGktldrni/kodi.txt

Unfortunately its too big for pastebin. I tried to highlight the lines with paragraphs. I also asked peak3d for help and whether it might be an input stream thing

[anxdpanic]

That looks like a whitelist issue, and not an add-on issue

2019-02-20 00:14:35.320 T:28956  NOTICE: Whitelist search for: width: 3840, height: 2160, fps: 59.000, 3D: false
2019-02-20 00:14:35.321 T:28956   DEBUG: Trying to find exact refresh rate
2019-02-20 00:14:35.321 T:28956   DEBUG: No exact whitelisted resolution matched, trying double refresh rate
2019-02-20 00:14:35.322 T:28956   DEBUG: No double refresh rate whitelisted resolution matched, trying current resolution
2019-02-20 00:14:35.322 T:28956   DEBUG: Current resolution doesn't match, trying default resolution
2019-02-20 00:14:35.323 T:28956   DEBUG: Default resolution doesn't provide reqired refreshrate, trying default resolution with double refreshrate
2019-02-20 00:14:35.323 T:28956   DEBUG: No whitelisted resolution matched
2019-02-20 00:14:35.323 T:28956  NOTICE: Display resolution ADJUST : 3840x2160 @ 60.000000 - Full Screen (16) (weight: 0.000)

2019-02-20 00:14:35.330 T:28956 DEBUG: CDVDVideoCodecAndroidMediaCodec::Open hints: fpsrate 59 / fpsscale 1 2019-02-20 00:14:35.388 T:28956 DEBUG: CDVDVideoCodecAndroidMediaCodec::UpdateFpsDuration fpsRate:59 fpsscale:1, fpsDur:16949

Looks the same for the 23 fps stream as well. peak3d will definitely have better insight than myself in this area.

[greystashh]

I have got an answer from peak3d: You have to write the fps values into rate / scale e.g. 24000/1001 instead of 23,97 https://github.com/peak3d/inputstream.adaptive/blob/master/src/parser/DASHTree.cpp#L589

[anxdpanic]

Your issue should be fixed with https://github.com/jdf76/plugin.video.youtube/pull/583/commits/14af80235fa120150f8f47c484e34190c79291dd , will likely bump the alpha before the end of the day

[anxdpanic]

@greystashh ~alpha3 includes the fix

[greystashh]

Thanks, it works now.