nutui icon indicating copy to clipboard operation
nutui copied to clipboard

fix: 修复 tour 组件无法根据 current 值展示指定步骤以及 change 事件得到的值有误

Open daiwanxing opened this issue 1 year ago • 6 comments

这个 PR 做了什么? (简要描述所做更改)

修复了当用户传入 current prop 时无效,组件未对 current 做处理,还修复了 onChange 事件得到的 step 的值计算错误

这个 PR 是什么类型? (至少选择一个)

  • [ ] feat: 新特性提交
  • [x] fix: bug 修复
  • [ ] docs: 文档改进
  • [ ] style: 组件样式/交互改进
  • [ ] type: 类型定义更新
  • [ ] perf: 性能、包体积优化
  • [ ] refactor: 代码重构、代码风格优化
  • [ ] test: 测试用例
  • [ ] chore(deps): 依赖升级
  • [ ] chore(demo): 演示代码改进
  • [ ] chore(locale): 国际化改进
  • [ ] chore: 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • [x] NutUI H5 @nutui/nutui
  • [x] NutUI Taro @nutui/nutui-taro

这个 PR 是否已自测:

Summary by CodeRabbit

Summary by CodeRabbit

  • 新功能
    • 更新了Tour组件的步骤转换逻辑,提升用户在切换步骤时的流畅度。
  • 代码重构
    • 优化了类属性的分配,将动态类绑定改为静态类分配。
    • 重构了计算属性,提高了代码可读性和维护性。
  • 样式
    • 引入了CSSProperties类型,增强了样式管理的一致性和可控性。

daiwanxing avatar Jul 12 '24 14:07 daiwanxing

Walkthrough

这些更改集中在 src/packages/__VUE/tour/index.taro.vue 文件内,主要涉及模板中类属性的修改,从绑定动态类变为静态类分配。此外,脚本部分引入了 CSSProperties,移除了 classes 计算属性,并对 changeStep 函数进行了控制流增强,以简化步骤转换和事件处理。

Changes

文件路径 更改摘要
src/packages/__VUE/tour/index.taro.vue 修改模板中的类属性分配,增加 CSSProperties 导入,移除 classes 计算属性,改进 changeStep 函数的控制流

Poem

代码如诗,优雅流,
类属性静态有,
脚步轻盈函数走,
风格新颖掌握手。
兔子欢跃庆更改,
未来无限乐陶陶。 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 12 '24 14:07 coderabbitai[bot]

#3138

daiwanxing avatar Jul 12 '24 14:07 daiwanxing

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.18%. Comparing base (a415d0b) to head (5f7c046). Report is 1 commits behind head on v4.

Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #3139      +/-   ##
==========================================
- Coverage   81.20%   81.18%   -0.02%     
==========================================
  Files         226      226              
  Lines       18139    18142       +3     
  Branches     2485     2485              
==========================================
  Hits        14729    14729              
- Misses       3392     3395       +3     
  Partials       18       18              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 12 '24 14:07 codecov[bot]

image

这个错误麻烦帮我看看原因 @eiinu

daiwanxing avatar Jul 12 '24 14:07 daiwanxing

image

这个错误麻烦帮我看看原因 @eiinu

似乎在当前组件内定义与 CSSProperties 类型有关的变量时都会报错,没有排查出具体的原因,可能与定义组件的方法有关系,用 any 暂时绕过吧。后续切换成 script + setup 应该就不会有这个问题了。

eiinu avatar Jul 26 '24 03:07 eiinu

image 这个错误麻烦帮我看看原因 @eiinu

似乎在当前组件内定义与 CSSProperties 类型有关的变量时都会报错,没有排查出具体的原因,可能与定义组件的方法有关系,用 any 暂时绕过吧。后续切换成 script + setup 应该就不会有这个问题了。

好的,调整了

daiwanxing avatar Jul 31 '24 13:07 daiwanxing