processing-py-site icon indicating copy to clipboard operation
processing-py-site copied to clipboard

Fix example syntax errors.

Open kazimuth opened this issue 11 years ago • 5 comments

Many examples have syntax errors. This should be fixed.

kazimuth avatar Aug 17 '14 14:08 kazimuth

Depending on how the input files are structured, it shouldn't be too hard to automate a presubmit test that checks for such errors. On Aug 17, 2014 10:18 AM, "James Gilles" [email protected] wrote:

Many examples have syntax errors. This should be fixed.

— Reply to this email directly or view it on GitHub https://github.com/kazimuth/processing-py-site/issues/37.

jdf avatar Aug 17 '14 14:08 jdf

It's a little wacky - they're embedded in xml files. We can run the build script, but a lot of things are broken in ways that aren't yet fixable, so something like travis will pretty much always say there are build errors. Do you think that would be helpful?

kazimuth avatar Aug 17 '14 14:08 kazimuth

I think it's always worth spending time as early as possible making things build clean so that you can meaningfully detect problems as they happen. On Aug 17, 2014 10:37 AM, "James Gilles" [email protected] wrote:

It's a little wacky - they're embedded in xml files. We can run the build script, but a lot of things are broken in ways that aren't yet fixable, so something like travis will pretty much always say there are build errors. Do you think that would be helpful?

— Reply to this email directly or view it on GitHub https://github.com/kazimuth/processing-py-site/issues/37#issuecomment-52423607 .

jdf avatar Aug 17 '14 14:08 jdf

Makes sense!

kazimuth avatar Aug 17 '14 15:08 kazimuth

I believe I caught all of the syntax errors as of #50. but the build process mentioned in this issue is still a good idea, so I'll leave open for now?

aparrish avatar Aug 24 '14 04:08 aparrish