Jason Desrosiers

Results 562 comments of Jason Desrosiers

This was too much for me to review manually, but I did run the tests through Hyperjump JSV and they all passed, so it looks good as far as I...

If it's a hassle, then it's not worth it. I wouldn't bother trying to get it working.

It turns out that the preview builds aren't working perfectly. The "Draft Specific" and "Language Specific" sections specifically don't render properly. Getting those issues working in local builds (#157) turned...

> Since the specification does define two possible ways to configure annotations as assertions I'd have to check the spec to make sure we didn't miss something, but the intention...

@karenetheridge, thanks for looking that up. Did we leave the implementation defined option in place on purpose, or did that slip through the cracks? I thought the point of splitting...

Rereading the relevant issues and PRs, it seems we decided this exactly how I remembered, but it was written up differently and we just went with it instead of going...

@gregsdennis I'm sorry I brought it up. It's really not important. I'm fine with how it is and I'm not even arguing for a change. I could quote a bunch...

I love this. I've been talking with @Relequestual about improving JSON Schema's documentation and content like this is part of the long term plan. Ideally, I'd like to start with...

The "simulate OpenAPI's `discriminator`" example should include `required` in all the `if`s. We can also include an example that uses this pattern with a default alternative (as described at https://json-schema.org/understanding-json-schema/reference/conditionals.html)

Cookbook idea: `contains` for draft-04 **Equivalent of `"contains": { ... schema ... }`** ```json "not": { "items": { "not": { ... schema ... } } } ``` **Full example** ```json...