django-dbconn-retry icon indicating copy to clipboard operation
django-dbconn-retry copied to clipboard

Published 20 hours ago • verified publisher icon jdelic

feat: support MAX_DBCONN_RETRY_TIMES

Open zhangzhw8 opened this issue 2 years ago • 2 comments

Thank you for the package! The dbconn_retry give up retry after retry once. Howerver, we found that sometimes retry more times could help! This PR support to set MAX_DBCONN_RETRY_TIMES in django.conf, which is default to be 1

Best Wishes

zhangzhw8 avatar Apr 07 '22 07:04 zhangzhw8

Hi there! I somehow had notifications on for this repo and found myself reviewing your PR before noticing. I hope you don't mind my comments. Generally, I'd advise adding some lines of documentation. Otherwise, people won't know about this setting. Maybe consider writing a test as well, to validate the new behavior works as expected. Best Joe!

Thank you for your advice. I've add settings description in README.rst and improve the test case. Please re-review.

zhangzhw8 avatar Apr 12 '22 07:04 zhangzhw8

😴

vrnvorona avatar Jul 17 '23 18:07 vrnvorona