jdef
jdef
@mihasya PTAL
@mihasya PTAL
@mihasya @wadey @rcrowley PTAL
OK @mihasya, what's your question?
@mihasya I don't see any additional comments. Mind taking a few seconds to re-review this change?
@mihasya PTAL
@mihasya PTAL
ouch, lots of missing docs. marking this WIP and adding docs now... ``` /go/src/github.com/dcos/dcos-go/future/future.go:11:6: exported type Interface should have comment or be unexported /go/src/github.com/dcos/dcos-go/future/future.go:15:6: exported type Func should have comment...
unrelated dcos-go-windows error: ``` go: github.com/Sirupsen/[email protected]: parsing go.mod: unexpected module path "github.com/sirupsen/logrus" go: error loading module requirements Failed to install github.com/Sirupsen/logrus at Install-GoDependencies, C:\Users\jenkins\workspace\public-dcos-go-windows\run-go-tests.ps1: line 219 at , C:\Users\jenkins\workspace\public-dcos-go-windows\run-go-tests.ps1: line...