Jason Wallace

Results 45 comments of Jason Wallace

@mtlynch - Just to be sure, I want to resolve these conflicts, is it safe for me to merge `master` directly into this branch (without a PR)?

@mtlynch - I've updated the description of this PR to showcase how I've tested the update-overhaul and what bugs I've found (so far). I've fixed most of the bugs as...

@mtlynch > > The /opt/tinypilot-updater directory is orphaned after an update. > > It's a pretty large directory, so I think we should deal with this now. I filed #1055....

##### Automated comment from [CodeApprove ➜](https://codeapprove.com/pr/tiny-pilot/tinypilot/1046) ⏳ @mtlynch please review this Pull Request

##### Automated comment from [CodeApprove ➜](https://codeapprove.com/pr/tiny-pilot/tinypilot/1046) ⏳ @jotaen4tinypilot please review this Pull Request

FYI when it comes to merging this PR the only option available is "Squash and merge", which I assume is okay: The reason why we might consider using "Create a...

> I think we should match the semantics of open(path, 'w'), so it should overwrite existing files. I agree with this.

> First question No, I'm not using it anymore. > Second question Yeah that would be useful. > Third question I haven't really thought about it yet, but your script...

Once we remove the TinyPilot repo and only rely on the TinyPilot Debian package, the [`build` step fails](https://app.circleci.com/pipelines/github/tiny-pilot/ansible-role-tinypilot/503/workflows/a098c9c1-87b0-48bd-b0e8-ab91c885d0c2/jobs/1118) because the TinyPilot Debian package is not part of this repo and...

@jotaen4tinypilot – We can't remove the `tinypilot_repo_branch` variable from `ansible-role-tinypilot` yet because molecule still builds TinyPilot using the git repo. We first need a way to pass the TinyPilot Debian...