pytorch-forecasting icon indicating copy to clipboard operation
pytorch-forecasting copied to clipboard
verified publisher icon jdb78

[MNT] Fix/linting

Open jdb78 opened this issue 1 year ago • 6 comments

jdb78 avatar Feb 10 '24 14:02 jdb78

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Feb 10 '24 14:02 review-notebook-app[bot]

Hi @Borda and @jdb78 What is the status of this PR? (and of this very useful project?) I see that all the other PR fail because this was not merged

MartinoMensio avatar Jun 07 '24 09:06 MartinoMensio

There is mix of fix to unblock CI and additionally update lints which generated a few more changes so likely would be easier to land when it will be splited

Borda avatar Jun 07 '24 10:06 Borda

Thanks for the info. Can I help by doing separate PR?

MartinoMensio avatar Jun 07 '24 10:06 MartinoMensio

I may give him a moment to react since it was on hold for a while or just please read it all and it land at once (with minor PR's title edit)

Borda avatar Jun 07 '24 11:06 Borda

Think some tests are actually not passing. Sorry, have lately not much time to work on the project. Would be very open to a co-maintainer!

jdb78 avatar Jun 16 '24 21:06 jdb78