pytorch-forecasting icon indicating copy to clipboard operation
pytorch-forecasting copied to clipboard

Issues with dependencies found

Open fpgmaas opened this issue 3 years ago • 0 comments

  • PyTorch-Forecasting version: master
  • PyTorch version: NA
  • Python version: 3.9.11

I applied deptry to this repository, and it found some dependency issues:

-----------------------------------------------------

pyproject.toml contains obsolete dependencies:

        networkx
        pytest-github-actions-annotate-failures

Consider removing them from your projects dependencies. If a package is used for development purposes, you should add
it to your development dependencies instead.

-----------------------------------------------------

There are dependencies missing from pyproject.toml:

        numba
        vmprof
        yaml

Consider adding them to your project's dependencies. 

-----------------------------------------------------

There are transitive dependencies that should be explicitly defined as dependencies in pyproject.toml:

        numpy
        requests
        torchmetrics
        tqdm

They are currently imported but not specified directly as your project's dependencies.

-----------------------------------------------------

It seems that networkx and pytest-github-actions-annotate-failures can be safely moved to dev-dependencies, and that numpy, requests, torchmetrics and tqdm should be added as explicit dependencies.

I am not familiar with numba and vmprof. I do see them being imported, but they are not mentioned in poetry.lock. Maybe someone else can shed more light on this? Are these part of cpflows?

Disclaimer: I am the author of deptry, so this is also a great opportunity for me to receive feedback

fpgmaas avatar Sep 09 '22 16:09 fpgmaas