jsformat-atom icon indicating copy to clipboard operation
jsformat-atom copied to clipboard

Published 20 hours ago • verified publisher icon jdavisclark

JSFormat should obey .jsbeautifyrc if file exists

Open pid opened this issue 10 years ago • 6 comments

It would be advantageous, if we don't have to "copy" the project specific jsbeautify config to the plugin /panel settings. The jsbeautifyrc file should overwrite the plugin/panel settings.

What do you think? I'm alone with this requirement? Or I'm using it currently wrong?

pid avatar Oct 04 '14 17:10 pid

No that makes sense, the only issue is if there is a conflict between jsbeautifyrc and editorconfig. Thoughts? Are there any conflicts?

ilanbiala avatar Oct 05 '14 00:10 ilanbiala

For reference, I'm currently looking into supporting .editorconfig files in the current project, so that's why I bring up the possible conflicts that may arise.

ilanbiala avatar Oct 05 '14 04:10 ilanbiala

the only issue is if there is a conflict between jsbeautifyrc and editorconfig. Thoughts? Are there any conflicts?

If someone has both files, they have to deal with it – bring it in sync by your own – everything else does not make sense to me. IMHO, my preference order: editor config/panel settings -> .editorconfig -> .jsbeautifyrc

pid avatar Oct 05 '14 07:10 pid

+1 on supporting .editorconfig files. Since we use 2 spaces for gulp, test and JSON files, 4 spaces for code.

glan avatar Oct 06 '14 21:10 glan

@glan but then what about supporting .jsbeautifyrc, or .jslintrc, etc. All these files will have conflicts, and having a priority in Atom's config is too complicated, so one file needs to be the reference for the project.

ilanbiala avatar Oct 07 '14 01:10 ilanbiala

FYI, v0.7.8 includes support for preserving newlines. Are there any other features other than tab size and tab format that need to be project-specific?

ilanbiala avatar Oct 09 '14 00:10 ilanbiala