jsformat-atom icon indicating copy to clipboard operation
jsformat-atom copied to clipboard

JSFormat should obey editorconfig if file exists

Open ilanbiala opened this issue 10 years ago • 4 comments

JSFormat should probably obey editorconfig, because it is per project where JSFormat is for all of Atom.

ilanbiala avatar Sep 20 '14 18:09 ilanbiala

+1 would be nice.

jdavisclark avatar Sep 20 '14 22:09 jdavisclark

Yes. Currently my files don't get a trailing newline even though I configured that in editorconfig (and installed the editorconfig atom plugin). I'd really like to have them back!

bsander avatar Sep 24 '14 12:09 bsander

@jdc0589 do you think that JSFormat has to build in support for this, or JSBeautify should try to build in support to accept an .editorconfig that is passed in and return the proper output? If JSBeautify does it, then no one else needs to repeat the code, which is good. However, JSBeautify contributors might say it's too much work or it isn't a focus of our project. Thoughts?

ilanbiala avatar Oct 03 '14 16:10 ilanbiala

:+1:

jesperronn avatar Oct 29 '14 13:10 jesperronn